Commit Graph
285 Commits
Author SHA1 Message Date
Joe Rickerby 9879937c63 Don't preinstall setuptools and wheel, remove from constraints
Reasons to do this:

- setuptools is no longer the only game in town. When cibuildwheel was created, setuptools was the only way to make wheels. these days, there are many build backends so special casing setuptools doesn't make so much sense
- we don't need to preinstall `wheel` any more, setuptools will do that itself when it needs it.
- projects with pyproject.toml (i.e. the vast majority of projects going forward) don't benefit from the pin anyway, because both `pip` and `build` create an isolated environment to install `build-system.requires` into.
- this makes it easier for end users (such as @webknjaz) to control build-system versions using `PIP_CONSTRAINT`, because there's less potential for a user-specified version to conflict with one of our pins.
  - (long-term, I'd love `build` to [support this directly](https://github.com/pypa/build/issues/292), and then we could have a proper way to keep pyproject.toml dependencies loose and forward-compatible while retaining build determinism. But PIP_CONSTRAINT is the best we have for now. PIP_CONSTRAINT isn't ideal because it affects other things, like the test virtualenv).

This PR also adds a pin for pypa/build. It appears that was missing before, but we should pin it.
2024-01-20 18:44:03 +00:00
Hugo van Kemenade e577a9fbdf Use quotes when silencing warning 2023-11-18 12:37:50 +02:00
Joe Rickerby 297e4a6099 Add args param to build-frontend option 2023-08-26 19:37:29 +01:00
Henry SchreinerandCosimo Lupo cee0848b49 fix: allow access to {wheel} in more places (#1533)
pass {wheel} path to test command so I can use with tox --installpkg

Co-authored-by: Cosimo Lupo <clupo@google.com>
2023-06-23 08:29:58 -04:00
Henry Schreiner 31bd9c9174 refactor: restore typing for non-backports
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
2023-04-18 23:29:01 -04:00
Henry Schreiner d996af554a fix: restore Python 3.7 support
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
2023-04-18 22:02:47 -04:00
Henry Schreiner 8c5f89c035 chore: update typing to be generic on function args
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
2023-04-18 13:06:17 -04:00
Henry Schreiner 6d038dfbdf chore: update typing to collections.abc
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
2023-04-18 12:38:21 -04:00
Henry Schreiner 2246313344 fix: verbosity isn't supported for pypa/build (#1474)
This was incorrectly adding an empty config setting, and it was not correct if included for build - it's a pip wheel only setting. Reported in #1471.

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
2023-04-17 14:06:45 -04:00
David Lechner fa72100d49 fix: overwriting wheel on windows shouldn't break (#1464)
fix overwriting wheel on windows

This is the same fix as #1129 but for Windows this time.
2023-04-17 14:06:14 -04:00
Hood Chatham 374d786812 Set pip as the default value of default 2023-04-08 18:26:09 -07:00
Hood Chatham 8a307031a9 Set the defualt build_frontend to be "default" (which is still "pip")
Instead of using pip as the default, set it to default. This way
each platform can choose independently what to do as the default
behavior.

This is intended as part of adding Pyodide support. Pyodide cannot
use pip as the build frontend. It always uses a modified pypa/build.
So if the build_frontend is explicitly set to pip we want to raise
an error. But if it's unset, then we should be able to tell and just
do what we want.
2023-04-07 15:56:17 -07:00
Hood Chatham d018570bc4 chore: add structurally typed GenericPythonConfiguration (#1458)
* Add structually typed GenericPythonConfiguration

Use structural typing for the return value of get_python_configurations
so that we don't have to specify a union of all possible PythonConfiguration
types

* address henryiii's comments

* Use Set in more places
2023-04-06 14:40:25 -04:00
Henry Schreiner 2e48667e29 refactor: use frontend instead of plural
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
2023-03-10 13:46:42 -05:00
Henry Schreiner c6818608d2 fix: pip config options were broken
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
2023-03-10 12:00:51 -05:00
Henry Schreiner 5ab3b55378 style: run pre-commit
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
2023-02-07 10:25:34 -05:00
Henry Schreiner c8b037ba3e chore: use Ruff (#1405)
chore: use ruff

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
2023-01-30 15:53:44 -05:00
Henry Schreiner 3dcc2ff07e fix: not skipping the tests stops the copy (Windows ARM) (#1377)
fix: not skipping the tests stops the copy

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
2022-12-22 11:22:13 -05:00
Joe Rickerby e4cbe81f3f Add test failure with descriptive error message when running tests without a {project} placeholder 2022-11-06 11:02:01 +00:00
Joe Rickerby 4a679749fa Suppress pylint warning 2022-10-16 12:33:09 +01:00
Joe Rickerby 61999a886b Merge pull request #1144 from zooba/arm64
Enable building for Windows ARM64 on a non-ARM64 device
2022-10-11 08:52:23 +01:00
Henry Schreiner 7c4bbf8cb3 chore: minor cleanups from reverb (#1293)
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
2022-10-07 08:47:31 -04:00
Steve Dower 4531370573 Rename variable to match one added to setuptools 2022-09-26 17:26:16 +01:00
Steve Dower 10a4e30a0b Merge remote-tracking branch 'upstream/main' into arm64 2022-09-26 17:25:03 +01:00
Henry Schreiner 534cada6a5 chore: cleaner exception tracebacks
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
2022-09-16 11:05:35 -04:00
Steve Dower 9815b9c580 Merge remote-tracking branch 'upstream/main' into arm64 2022-09-09 11:51:13 +01:00
Henry Schreiner 3597095948 feat: support config-settings (#1244)
* feat: support config-settings

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>

feat: support config-settings

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>

* refactor: use shlex.quote

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
2022-09-06 00:56:20 -04:00
Steve Dower 5030c2c698 Remove unused names 2022-09-02 17:49:38 +01:00
Steve Dower ff2d9de338 Flow through tmp directory 2022-09-01 22:15:57 +01:00
Steve Dower 1d7054c022 Switch to potential new distutils environment variable 2022-09-01 22:13:08 +01:00
Steve Dower 9dc55127ff Fix typing 2022-08-31 21:24:47 +01:00
pre-commit-ci[bot] 7b0ac9e107 [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
2022-08-31 20:08:59 +00:00
Steve Dower f277099850 Skip ARM64 tests automatically with warning, and improved cleanup 2022-08-31 21:08:15 +01:00
Steve Dower 9a4e8f671f Actually call unlink, and add more typing 2022-08-25 16:48:49 +01:00
Steve Dower dcc5c00a3d Ensure cfg is removed, and add a message 2022-08-24 00:32:20 +01:00
pre-commit-ci[bot] b8ac98ee9f [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
2022-08-23 19:39:24 +00:00
Steve Dower 09e08f6342 Write to ~/pydistutils.cfg instead, preserving any existing file 2022-08-23 20:38:23 +01:00
Steve Dower c3dcb07fb6 Revert type names 2022-08-01 20:29:51 +01:00
pre-commit-ci[bot] 4c73245a7f [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
2022-08-01 19:26:31 +00:00
Steve Dower 9405d827b1 Merge branch 'arm64' of https://github.com/zooba/cibuildwheel into arm64 2022-08-01 20:23:57 +01:00
Steve Dower 94a053e024 Apply some PR feedback 2022-08-01 20:23:30 +01:00
pre-commit-ci[bot] a2386a2d80 [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
2022-08-01 19:12:17 +00:00
Steve Dower 59febc16d1 Add setup_rust_cross_compile 2022-08-01 20:11:47 +01:00
Steve Dower 71df33df55 Merge remote-tracking branch 'upstream/main' into arm64 2022-08-01 19:54:50 +01:00
mayeut 6d27f05c7c chore: use from __future__ import annotations 2022-07-19 07:47:45 +02:00
Henry Schreiner 9ed9e6b960 Merge branch 'main' into already-built 2022-07-03 14:02:42 -04:00
9a537512c1 feat: add support for py3-none-{platform} wheels (#1151)
* feature: add support for `py3-none-{platform}` wheels

This extends the mechanism introduced in #1091 for `abi3` wheels.
Most of the mentions to `abi3` have been removed and replaced by a more generic `compatible_wheel`.
This allows to build a wheel `foo-0.1-py3-none-win_amd64.whl` only once and still test with every configured python.

* Add integration test for py3-none abi wheels

* Fix expected_wheels for py3-none abi

* Limit test to three pythons and check for certain log messages

* chore: add some comments to explain filter process

Co-authored-by: Joe Rickerby <joerick@mac.com>
Co-authored-by: Henry Schreiner <henryschreineriii@gmail.com>
2022-07-03 14:00:00 -04:00
mayeut ef18186c45 fix: error out if multiple wheels with the same name are produced
We shouldn't silently overwrite wheels that are produced in the same run that have the same filename, as this implies a misconfiguration.
2022-06-26 11:32:33 +02:00
mayeut 0696c94710 feature: add support for py3-none-{platform} wheels
This extends the mechanism introduced in #1091 for `abi3` wheels.
Most of the mentions to `abi3` have been removed and replaced by a more generic `compatible_wheel`.
This allows to build a wheel `foo-0.1-py3-none-win_amd64.whl` only once and still test with every configured python.
2022-06-26 11:31:59 +02:00
Joe Rickerby cdccbd1c46 Merge remote-tracking branch 'origin/main' into henryiii/refactor/namespace 2022-06-17 18:08:17 +01:00