Commit Graph
7 Commits
Author SHA1 Message Date
Gertjan van den Burg 5210ad3610 clarify comment at if statement 2019-11-08 10:53:18 +00:00
Gertjan van den Burg def8f9a2e3 Remove errexit flag for test command subshell 2019-11-08 10:53:06 +00:00
Gertjan van den Burg f716f87a04 Merge branch 'master' into returncode 2019-11-08 10:51:49 +00:00
Gertjan van den Burg 560c1adeb7 Merge branch 'master' into returncode 2019-11-05 17:09:17 +00:00
Gertjan van den Burg e0eb375449 Returncode fix (#1)
Some trial and error to make sure it works reliably.

* remove test_retcode
* debug local bash settings
* set errexit explicitly in subshell
* set errexit also in the subshell in parenthesis
* debugging
* more debugging (exit code of sh)
* is the venv subshell returning exit 1?
* what if we remove the additional subshell?
* then we need to unquote the command
* if statement needs test command quoted
* simple if statement
* echo command needs to be removed of course
* remove debug statements
* check if setting errexit here is needed
* these settings can be removed
  At this point ("before") the shell already has errexit set.
* setting errexit in the sh invocation is needed
  This is not inherited, so it's good to specify it.
* just double checking that the subshell doesn't exit
* use solution from fvue.nl
* Solution doesn't seem to work, even popd is run
  So now I'm putting back the if statement, it seems
  to be the simplest and most effective solution.
* add a comment
* prove that errexit is necessary
* errexit is indeed needed for chaining
2019-10-21 11:42:43 +01:00
Gertjan van den Burg 0c33a58579 failing test breaks out of subshell 2019-10-18 11:45:48 +01:00
Gertjan van den Burg 3842cfd853 Attempt at getting the retcode of the test process 2019-10-18 11:31:48 +01:00