Commit Graph
100 Commits
Author SHA1 Message Date
bf817c6dc8 refactor: error handling to use exceptions (#1719)
* Refactor error handling to use exceptions

cibuildwheel has up until now handled most errors by printing an error message to sys.stderr and calling sys.exit. Others were handled using Logger.error, depending on the context. We also had return codes, but these weren't explicitly defined anywhere.

This makes that convention more explicit and codified. Now to halt the program, the correct thing to do is to throw a cibuildwheel.errors.FatalError exception - that is caught in main() and printed before exiting. The existing behaviour was kept - if an error occurs within a build step (probably something to do with the build itself), the Logger.error() method is used. Outside of a build step (e.g. a misconfiguration), the behaviour is still to print 'cibuildwheel: <message>'

I also took the opportunity to add a debugging option `--debug-traceback` (and `CIBW_DEBUG_TRACEBACK`), which you can enable to see a full traceback on errors.

(I've deactivated the flake8-errmsg lint rule, as it was throwing loads of errors and these error messages aren't generally seen in a traceback context)

* add noqa rule

* Apply suggestions from code review

Co-authored-by: Henry Schreiner <HenrySchreinerIII@gmail.com>

* Return to flake8-errmsg conformance

* Code review suggestions

* Subclass Exception rather than SystemExit

* apply error handling to new code and fix merge issues

* Apply review suggestion

* fix: merge issue

* Update cibuildwheel/errors.py

---------

Co-authored-by: Henry Schreiner <HenrySchreinerIII@gmail.com>
Co-authored-by: mayeut <mayeut@users.noreply.github.com>
2024-06-10 10:36:20 -04:00
Joe Rickerby 9d5f5e60b8 Make container-engine a build (non-global) option (#1792) 2024-05-20 02:47:10 -04:00
Joe Rickerby 98d57d9547 Merge pull request #1766 from Czaki/delocate_info
Add information about new delocate error "Library dependencies do not satisfy target MacOS"
2024-04-26 10:57:22 +01:00
Joe Rickerby 8daac05d63 Merge pull request #1811 from radarhere/actions/setup-python
Updated actions/setup-python in docs
2024-04-26 10:54:23 +01:00
Joe Rickerby 6537b8f51f Merge pull request #1795 from pypa/pre-commit-ci-update-config 2024-03-19 18:55:38 +00:00
Joe Rickerby 3eb6dbbdd3 Fix typo in changelog 2024-03-11 21:28:09 +00:00
Joe Rickerby 90c14a333f Improve version push command 2024-03-11 21:24:21 +00:00
Joe Rickerby 8d945475ac Bump version: v2.17.0 2024-03-11 21:19:43 +00:00
Joe Rickerby ca06deb26f Merge pull request #1775 from pypa/doc-domain
Docs domain change to cibuildwheel.pypa.io
2024-03-11 21:17:51 +00:00
Joe Rickerby f7e1922225 CirrusCI fixes (#1786)
* Fix executable name, that doesn't always exist on windows

* Use the `python3` executable on macOS Cirrus

* Homebrew changed where it puts the python binaries

* Update examples to match new config
2024-03-11 20:54:37 +00:00
Joe Rickerby 022de07dc1 Merge pull request #1785 from pypa/revert-1783
Remove manylinux1 docker pin
2024-03-11 09:21:03 +00:00
Joe Rickerby 920f574191 Remove manylinux1 docker pin 2024-03-11 09:05:43 +00:00
Joe Rickerby 5c06f3c289 docs: Add how to run tests in development (#1698)
* Add docs for how to run tests in development

* Update the docs to use nox primarily and not require CIBW_PLATFORM

* Reorganise this file
2024-03-10 21:37:07 -04:00
Joe Rickerby f7de18e291 Merge pull request #1675 from pypa/pip-constraints-fix
fix: Don't override PIP_CONSTRAINT if set by the user
2024-03-09 13:53:32 +00:00
Joe Rickerby 80095ac7af Merge pull request #1745 from mayeut/nopipx
chore(action): do not use pipx
2024-03-09 13:53:17 +00:00
Joe Rickerby df2e35a016 Merge pull request #1783 from henryiii/henryiii/ci/pinmanylinux1
ci: pin manylinux1 with missing tag
2024-03-09 13:43:46 +00:00
Joe Rickerby b71a83d411 Docs domain change to cibuildwheel.pypa.io 2024-03-04 10:37:01 +00:00
Joe Rickerby 6940c77cd3 style improvements from code review 2024-03-02 18:16:20 +00:00
Joe Rickerby 554726e3c4 Merge pull request #1727 from pypa/dont-require-platform
Don't require `--platform` when running on a development machine
2024-02-28 09:20:25 +00:00
Joe Rickerby 8742ff2ef8 Merge pull request #1725 from pypa/constraints-cleanup
Don't preinstall setuptools and wheel, remove from constraints
2024-02-28 09:16:30 +00:00
Joe Rickerby 75627e8ca4 Limit line length to 100 cols 2024-02-28 09:11:06 +00:00
Joe Rickerby 3ae9aa1da5 Update constraints again to reapply changes to constraints.in after merge 2024-02-27 21:46:07 +00:00
Joe Rickerby f04a522d50 Merge remote-tracking branch 'origin/main' into constraints-cleanup 2024-02-27 21:44:03 +00:00
Joe Rickerby edd67e0d26 Merge pull request #1734 from pypa/gha-images-latest
Don't bother pinning OS images for Github Actions
2024-02-27 21:37:11 +00:00
Joe Rickerby 8a8c07d4f9 Merge pull request #1763 from pypa/update-dependencies-pr
[Bot] Update dependencies
2024-02-27 21:33:33 +00:00
Joe Rickerby 74afe329a1 Merge remote-tracking branch 'origin/main' into constraints-cleanup 2024-02-27 21:28:54 +00:00
Joe Rickerby 7ada127bfc Remove loop with single entry in test 2024-02-27 21:26:16 +00:00
Joe RickerbyandMatthieu Darbois 88d60dce89 Update .github/workflows/test.yml
Co-authored-by: Matthieu Darbois <mayeut@users.noreply.github.com>
2024-02-18 18:52:42 +00:00
Joe Rickerby 27d0942e1c Merge pull request #1754 from pypa/dependabot/github_actions/actions-894fc5cb1d
chore(deps): bump the actions group with 1 update
2024-02-06 22:01:28 +00:00
Joe Rickerby 68f1058d7e Merge pull request #1755 from pypa/pre-commit-ci-update-config
[pre-commit.ci] pre-commit autoupdate
2024-02-06 21:56:27 +00:00
Joe Rickerby d65d46ca24 Merge remote-tracking branch 'origin/main' into pip-constraints-fix 2024-02-04 11:18:10 +00:00
Joe Rickerby 88c113402d Merge pull request #1750 from njzjz/macos-test-venv
test macos-x86_64 and arm64 in different venv dir
2024-02-03 14:55:58 +00:00
Joe Rickerby 6c93c131c4 Go back to macos-12 for the AS transition 2024-02-02 17:56:34 +00:00
Joe Rickerby d635c0eee6 Add integration test 2024-02-02 17:51:54 +00:00
Joe Rickerby ce3fb78320 Bump version: v2.16.5 2024-01-30 23:14:28 +00:00
Joe Rickerby a7ea5fb408 Merge pull request #1739 from henryiii/henryiii/chore/checkschemas
chore: check schemas
2024-01-30 20:27:46 +00:00
Joe Rickerby bc55e8bf0a Merge pull request #1741 from jborean93/pwsh-7.4
Add support for PowerShell 7.3 in GHA
2024-01-30 20:16:51 +00:00
Joe Rickerby 0b04ab1040 Bump version: v2.16.4 2024-01-28 17:21:43 +00:00
Joe Rickerby 3bf1908dcb Don't bother pinning OS images for Github Actions
Fix #1612

The hassle of updating these pins (both for us and our users, most copy our documentation) seems to outweigh the benefit of the pin. The truth is that they're not really pins anyway, Github update them all the time, and they don't work for historical repeatability because old images are retired all the time.
2024-01-27 11:21:22 +00:00
Joe Rickerby 4a79413fe6 Remove the Cirrus CI badge from readme
It frequently gives false negatives because of limited compute credits
2024-01-27 11:09:41 +00:00
Joe Rickerby e250df5d5d Bump version: v2.16.3 2024-01-26 19:21:57 +00:00
Joe Rickerby ddc2c6e845 Make the note on environment variables clear 2024-01-26 18:52:47 +00:00
Joe Rickerby fd0aae31e3 Merge pull request #1686 from doronz88/refactor/doc-linux-clarification
doc: add clarification regarding linux docker environment
2024-01-26 18:48:27 +00:00
Joe Rickerby 2a83588552 Apply suggestions from code review 2024-01-26 18:48:10 +00:00
Joe Rickerby 4db49f5485 Don't require --platform when running on a development machine
Historically, we required `--platform` when running cibuildwheel outside of CI, because cibuildwheel would attempt to globally install Python interpreters and some packages.

That was fixed in https://github.com/pypa/cibuildwheel/pull/974 a couple of years ago. As a result, there's no reason to require --platform these days, the `auto` behaviour is perfectly fine for dev machines.

It also makes running tests locally simpler, one can just do `pytest test/test_0_basic.py` (or `nox -s tests -- test/test_0_basic.py`) and not have to worry about setting CIBW_PLATFORM most of the time.
2024-01-21 18:24:43 +00:00
Joe Rickerby 23a6e88b0c Merge pull request #1672 from pypa/disable-host-mount
feat: Adds disable_host_mount suboption to container-engine
2024-01-20 19:05:12 +00:00
Joe Rickerby 4ca5d7cd2a We can't update the 3.6 pins in CI 2024-01-20 19:04:10 +00:00
Joe Rickerby 9879937c63 Don't preinstall setuptools and wheel, remove from constraints
Reasons to do this:

- setuptools is no longer the only game in town. When cibuildwheel was created, setuptools was the only way to make wheels. these days, there are many build backends so special casing setuptools doesn't make so much sense
- we don't need to preinstall `wheel` any more, setuptools will do that itself when it needs it.
- projects with pyproject.toml (i.e. the vast majority of projects going forward) don't benefit from the pin anyway, because both `pip` and `build` create an isolated environment to install `build-system.requires` into.
- this makes it easier for end users (such as @webknjaz) to control build-system versions using `PIP_CONSTRAINT`, because there's less potential for a user-specified version to conflict with one of our pins.
  - (long-term, I'd love `build` to [support this directly](https://github.com/pypa/build/issues/292), and then we could have a proper way to keep pyproject.toml dependencies loose and forward-compatible while retaining build determinism. But PIP_CONSTRAINT is the best we have for now. PIP_CONSTRAINT isn't ideal because it affects other things, like the test virtualenv).

This PR also adds a pin for pypa/build. It appears that was missing before, but we should pin it.
2024-01-20 18:44:03 +00:00
Joe Rickerby c18f6cba12 Empty commit to trigger TravisCI 2024-01-19 17:30:38 +00:00
Joe Rickerby c9765e9dc2 Merge pull request #1712 from pypa/update-dependencies-pr
[Bot] Update dependencies
2023-12-29 12:03:11 +00:00
Joe Rickerby 056a543dd9 Merge pull request #1708 from alugowski/readme
docs: update to readme example to `upload-artifact` v4
2023-12-21 18:40:14 +00:00
Joe Rickerby 6e2f4c00ab Merge pull request #1697 from abitrolly/diagram-html
Rename `diagram.md` to `diagram.html`, because it is HTML
2023-12-20 16:56:20 +00:00
Joe Rickerby d371852317 Merge pull request #1696 from pypa/pre-commit-ci-update-config
[pre-commit.ci] pre-commit autoupdate
2023-12-19 18:26:38 +00:00
Joe Rickerby a3e5b541dc Update LICENSE year 2023-12-13 08:53:18 +00:00
Joe Rickerby 886ba0f662 Merge pull request #1681 from pypa/pre-commit-ci-update-config
[pre-commit.ci] pre-commit autoupdate
2023-12-06 18:20:31 +00:00
Joe Rickerby 8e9a703abc Merge pull request #1678 from pypa/update-dependencies-pr
[Bot] Update dependencies
2023-12-06 18:20:09 +00:00
Joe Rickerby 4dba644b8d Merge pull request #1667 from pypa/joerick-patch-1
docs: Address some confusion around the CIBW_ENVIRONMENT option.
2023-12-06 18:19:12 +00:00
Joe Rickerby 4cedf1c603 Docs formatting tweaks 2023-11-27 22:51:13 +00:00
Joe Rickerby 796361d9f9 Merge pull request #1680 from webknjaz/patch-2
[docs] Drop `wheel` from `pyproject.toml` example @ options page
2023-11-27 22:41:27 +00:00
Joe Rickerby a4f8eb3544 Merge pull request #1679 from webknjaz/patch-1
Stop suggesting adding `wheel` to `pyproject.toml`
2023-11-27 16:38:48 +00:00
Joe Rickerby 2a1edad716 Backslashes in Windows paths mess with CIBW_ENVIRONMENT string parsing 2023-11-24 19:08:04 +00:00
Joe Rickerby c2b03ead3e Fix test issue around container paths 2023-11-24 15:12:49 +00:00
Joe Rickerby d198c90f7a Allow the user to set PIP_CONSTRAINT and it affect build-system.requires 2023-11-24 11:49:26 +00:00
Joe Rickerby 6c6c51ef3b Merge pull request #1665 from hugovk/skip-quotes
Use quotes when silencing warning
2023-11-24 10:36:43 +00:00
Joe Rickerby a6345190fa Skip test on gitlab too 2023-11-24 10:33:21 +00:00
Joe Rickerby ebf48d4122 Merge pull request #1668 from pypa/update-dependencies-pr
[Bot] Update dependencies
2023-11-23 13:50:47 +00:00
Joe Rickerby 9213ca194d Merge pull request #1670 from pypa/pre-commit-ci-update-config
[pre-commit.ci] pre-commit autoupdate
2023-11-23 13:50:32 +00:00
Joe Rickerby b371ae35d1 Merge pull request #1674 from rossarmstrong/main
Update projects.yml to add new repo for working examples
2023-11-23 13:50:15 +00:00
Joe Rickerby 7c99262c00 Adds disable_host_mount suboption to container-engine 2023-11-21 22:25:20 +00:00
Joe Rickerby 39d9b00eeb [docs] Address some confusion around the CIBW_ENVIRONMENT option.
Ref #1666
2023-11-19 13:04:19 +00:00
Joe Rickerby 81812d05a3 Merge pull request #1661 from pypa/pre-commit-ci-update-config
[pre-commit.ci] pre-commit autoupdate
2023-11-14 13:54:54 +00:00
Joe Rickerby fff9ec32ed Bump version: v2.16.2 2023-10-03 20:07:09 +01:00
Joe Rickerby f4291e7492 Merge pull request #1617 from pypa/env-order
fix: evaluate environment-pass before environment, so environment can reference or override those variables
2023-10-03 18:25:19 +01:00
Joe Rickerby 9da4ede616 Merge pull request #1620 from Helveg/cibw-debug-keep-container
feat: `CIBW_DEBUG_KEEP_CONTAINER`: debug container after build
2023-10-03 18:23:49 +01:00
Joe Rickerby 77d3a5f98e Merge pull request #1621 from pypa/parse-kvs-colons
fix: improve parse_key_value_string to allow colons in values
2023-10-03 18:20:24 +01:00
Joe Rickerby 9535d168fa Merge pull request #1629 from henryiii/henryiii/refactor/schemaref
refactor: use refs instead of copies
2023-10-03 18:19:53 +01:00
Joe Rickerby 70fae8d0b7 Merge pull request #1630 from mayeut/manylinux-interpreters
feat: use manylinux-interpreters tool if present
2023-10-03 18:16:59 +01:00
Joe Rickerby 7699db3017 Merge pull request #1632 from gdementen/patch-1
docs: fix typo in changelog
2023-10-03 18:13:57 +01:00
Joe Rickerby 6dceb29008 Merge pull request #1634 from pypa/pre-commit-ci-update-config
[pre-commit.ci] pre-commit autoupdate
2023-10-03 18:12:54 +01:00
Joe Rickerby 035f5a2297 Merge pull request #1635 from pypa/update-dependencies-pr
[Bot] Update dependencies
2023-10-03 18:12:08 +01:00
Joe Rickerby 96e0efe076 Merge pull request #1631 from pypa/update-dependencies-pr
[Bot] Update dependencies
2023-10-02 15:16:27 +01:00
Joe Rickerby 7da7df1efc Bump version: v2.16.1 2023-09-26 10:52:04 +02:00
Joe Rickerby 9deb1b6794 Merge pull request #1625 from pypa/update-dependencies-pr
[Bot] Update dependencies
2023-09-26 09:44:46 +01:00
Joe Rickerby 687981060f Improve parse_key_value_string to allow colons in values.
Fix #1600
2023-09-19 14:05:36 +01:00
Joe Rickerby 29cb13893f Merge remote-tracking branch 'origin/main' into env-order 2023-09-19 11:59:12 +01:00
Joe Rickerby 099d397aee Merge pull request #1599 from mayeut/manylinux-entrypoint
fix: do not use `linux32` when unnecessary
2023-09-19 11:56:45 +01:00
Joe Rickerby a873dd9cbf Bump version: v2.16.0 2023-09-18 18:34:53 +01:00
Joe Rickerby e8ba0d49ed Merge pull request #1615 from pypa/dependabot/github_actions/docker/setup-qemu-action-3
chore(deps): bump docker/setup-qemu-action from 2 to 3
2023-09-18 18:19:19 +01:00
Joe Rickerby f0feaffbaa Merge pull request #1613 from henryiii/henryiii/fix/mainif
fix(setup.py): look inside if name == main block
2023-09-18 18:16:04 +01:00
Joe Rickerby 80a54b0226 Merge pull request #1589 from dalcinl/source_date_epoch
feature: Automatically pass SOURCE_DATE_EPOCH to Linux containers
2023-09-18 18:15:13 +01:00
Joe Rickerby 76dba0b9ba Merge pull request #1588 from pypa/frontend-flags
Add the ability to pass extra flags to a build frontend through CIBW_BUILD_FRONTEND
2023-09-18 18:14:42 +01:00
Joe Rickerby 391249a1ca Merge remote-tracking branch 'origin/main' into env-order 2023-09-18 17:39:08 +01:00
Joe Rickerby 0954ffaa65 Merge pull request #1618 from pypa/rtd-update
Update RtD config to include mandatory build.os option
2023-09-18 17:25:54 +01:00
Joe Rickerby 753cbd1ca5 Update RtD config to include mandatory build.os option 2023-09-18 17:20:30 +01:00
Joe Rickerby 825d89818a Merge pull request #1614 from henryiii/henryiii/chore/minor
chore: minor additions
2023-09-18 17:15:21 +01:00
Joe Rickerby 62a06d28b5 Change order of environment-pass, so environment can reference it 2023-09-18 17:08:30 +01:00
Joe Rickerby 647b509c74 Add test for environment and environment_pass references 2023-09-18 17:06:09 +01:00
Joe Rickerby e5d0cc0b0d Merge pull request #1598 from henryiii/henryiii/chore/checkoutv4
chore: use actions/checkout@4 everywhere
2023-09-06 10:13:35 +01:00
Joe Rickerby 001f11c755 Merge pull request #1591 from pypa/pre-commit-ci-update-config
[pre-commit.ci] pre-commit autoupdate
2023-09-01 11:45:01 +01:00
Joe Rickerby 5f37a3bb02 Merge pull request #1590 from pypa/update-dependencies-pr
[Bot] Update dependencies
2023-09-01 11:44:39 +01:00