Hongru/cibuildwheel
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: set SYSTEM_VERSION_COMPAT=0 during pip install on macos (#1768)

Browse Source 
* Set SYSTEM_VERSION_COMPAT=0 during pip install on macos (#1767)

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Only set SYSTEM_VERSION_COMPAT=0 for CPython 3.8

* Set SYSTEM_VERSION_COMPAT=0 for CPython <= 3.8

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update cibuildwheel/macos.py

Co-authored-by: Joe Rickerby <joerick@mac.com>

* Update cibuildwheel/macos.py

Co-authored-by: Joe Rickerby <joerick@mac.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Joe Rickerby <joerick@mac.com>
This commit is contained in:
laggykiller
2024-03-10 21:36:36 -04:00
committed by GitHub
co-authored by Joe Rickerby pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
parent 87fff77282
commit e2a0839555
1 changed files with 22 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
cibuildwheel/macos.py
+22 -2
View File
@@ -583,17 +583,37 @@ def build(options: Options, tmp_path: Path) -> None:
shell_with_arch(before_test_prepared, env=virtualenv_env) shell_with_arch(before_test_prepared, env=virtualenv_env)
# install the wheel # install the wheel
if is_cp38 and python_arch == "x86_64":
virtualenv_env_install_wheel = virtualenv_env.copy()
virtualenv_env_install_wheel["SYSTEM_VERSION_COMPAT"] = "0"
log.notice(
unwrap(
"""
Setting SYSTEM_VERSION_COMPAT=0 to ensure CPython 3.8 can get
correct macOS version and allow installation of wheels with
MACOSX_DEPLOYMENT_TARGET >= 11.0.
See https://github.com/pypa/cibuildwheel/issues/1767 for the
details.
"""
)
)
else:
virtualenv_env_install_wheel = virtualenv_env
call_with_arch( call_with_arch(
"pip", "pip",
"install", "install",
f"{repaired_wheel}{build_options.test_extras}", f"{repaired_wheel}{build_options.test_extras}",
env=virtualenv_env, env=virtualenv_env_install_wheel,
) )
# test the wheel # test the wheel
if build_options.test_requires: if build_options.test_requires:
call_with_arch( call_with_arch(
"pip", "install", *build_options.test_requires, env=virtualenv_env "pip",
"install",
*build_options.test_requires,
env=virtualenv_env_install_wheel,
) )
# run the tests from a temp dir, with an absolute path in the command # run the tests from a temp dir, with an absolute path in the command