From d9b4644286a9b41172b15fcd2a8b40f16c851dd6 Mon Sep 17 00:00:00 2001 From: Joe Rickerby Date: Mon, 27 Jun 2022 15:23:50 +0100 Subject: [PATCH] Don't need shell for this command --- cibuildwheel/docker_container.py | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/cibuildwheel/docker_container.py b/cibuildwheel/docker_container.py index f62ee557..de41ded9 100644 --- a/cibuildwheel/docker_container.py +++ b/cibuildwheel/docker_container.py @@ -195,10 +195,13 @@ class DockerContainer: if self.container_engine == "podman": # There is a bug in docker that prevents this simple implementation # from working https://github.com/moby/moby/issues/38995 - command = f"{self.container_engine} cp {self.name}:{shell_quote(from_path)}/. {shell_quote(to_path)}" subprocess.run( - command, - shell=True, + [ + self.container_engine, + "cp", + f"{self.name}:{from_path}/.", + str(to_path), + ], check=True, cwd=to_path, )