chore: add PyLint and fix most issues (#999)

* chore: add PyLint and fix most issues

* fix: minor fixes after first push

* chore: remove reference to old toml lib

* chore: minor options cleanup

* ci: only fail with many pylint issues, annotate in GHA

* refactor: address review

* ci: force nox to report in CI

* refactor: use map instead of if chain

* refactor: simpler shell_with_arch

* refactor: even simpler shell_with_arch

* Restore if...elif...else blocks where guard-style is not intended

Co-authored-by: Joe Rickerby <joerick@mac.com>

cibuildwheel/linux.py

@@ -303,11 +303,11 @@ def build_on_docker(
     log.step_end()
 
 
-def build(options: Options, tmp_path: Path) -> None:
+def build(options: Options, tmp_path: Path) -> None:  # pylint: disable=unused-argument
     try:
         # check docker is installed
         subprocess.run(["docker", "--version"], check=True, stdout=subprocess.DEVNULL)
-    except Exception:
+    except subprocess.CalledProcessError:
         print(
             "cibuildwheel: Docker not found. Docker is required to run Linux builds. "
             "If you're building on Travis CI, add `services: [docker]` to your .travis.yml."