From df04fa5ac3dcab0a758d0714a9cb6db01da858b7 Mon Sep 17 00:00:00 2001 From: Joe Rickerby Date: Fri, 13 Nov 2020 14:57:09 +0000 Subject: [PATCH 1/3] Use set -o errexit in the Azure example --- examples/azure-pipelines-minimal.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/examples/azure-pipelines-minimal.yml b/examples/azure-pipelines-minimal.yml index 498af96d..34043b05 100644 --- a/examples/azure-pipelines-minimal.yml +++ b/examples/azure-pipelines-minimal.yml @@ -4,6 +4,7 @@ jobs: steps: - task: UsePythonVersion@0 - bash: | + set -o errexit python3 -m pip install --upgrade pip pip3 install cibuildwheel==1.6.4 cibuildwheel --output-dir wheelhouse . @@ -15,6 +16,7 @@ jobs: steps: - task: UsePythonVersion@0 - bash: | + set -o errexit python3 -m pip install --upgrade pip pip3 install cibuildwheel==1.6.4 cibuildwheel --output-dir wheelhouse . @@ -28,6 +30,7 @@ jobs: - script: choco install vcpython27 -f -y displayName: Install Visual C++ for Python 2.7 - bash: | + set -o errexit python -m pip install --upgrade pip pip install cibuildwheel==1.6.4 cibuildwheel --output-dir wheelhouse . From c56448eba71c47fe04aa2bd2bf8144df06ffc224 Mon Sep 17 00:00:00 2001 From: Joe Rickerby Date: Fri, 13 Nov 2020 19:20:16 +0000 Subject: [PATCH 2/3] Named steps and set -o errexit --- examples/azure-pipelines-minimal.yml | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/examples/azure-pipelines-minimal.yml b/examples/azure-pipelines-minimal.yml index 34043b05..a178ac9c 100644 --- a/examples/azure-pipelines-minimal.yml +++ b/examples/azure-pipelines-minimal.yml @@ -7,7 +7,8 @@ jobs: set -o errexit python3 -m pip install --upgrade pip pip3 install cibuildwheel==1.6.4 - cibuildwheel --output-dir wheelhouse . + - displayName: Build wheels + bash: cibuildwheel --output-dir wheelhouse . - task: PublishBuildArtifacts@1 inputs: {pathtoPublish: 'wheelhouse'} @@ -15,13 +16,15 @@ jobs: pool: {vmImage: 'macOS-10.15'} steps: - task: UsePythonVersion@0 - - bash: | + - displayName: Install dependencies + bash: | set -o errexit python3 -m pip install --upgrade pip - pip3 install cibuildwheel==1.6.4 - cibuildwheel --output-dir wheelhouse . + python3 -m pip install cibuildwheel==1.6.4 + - displayName: Build wheels + bash: cibuildwheel --output-dir wheelhouse . - task: PublishBuildArtifacts@1 - inputs: {pathtoPublish: 'wheelhouse'} + inputs: {pathtoPublish: wheelhouse} - job: windows pool: {vmImage: 'vs2017-win2016'} @@ -33,6 +36,7 @@ jobs: set -o errexit python -m pip install --upgrade pip pip install cibuildwheel==1.6.4 - cibuildwheel --output-dir wheelhouse . + - displayName: Build wheels + bash: cibuildwheel --output-dir wheelhouse . - task: PublishBuildArtifacts@1 inputs: {pathtoPublish: 'wheelhouse'} From d054b45ecff50f3d44b43a603a3926ddb6f84cee Mon Sep 17 00:00:00 2001 From: Joe Rickerby Date: Sat, 14 Nov 2020 14:33:58 +0000 Subject: [PATCH 3/3] Perhaps displayName must come second --- examples/azure-pipelines-minimal.yml | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/examples/azure-pipelines-minimal.yml b/examples/azure-pipelines-minimal.yml index a178ac9c..bda80c68 100644 --- a/examples/azure-pipelines-minimal.yml +++ b/examples/azure-pipelines-minimal.yml @@ -7,8 +7,9 @@ jobs: set -o errexit python3 -m pip install --upgrade pip pip3 install cibuildwheel==1.6.4 - - displayName: Build wheels - bash: cibuildwheel --output-dir wheelhouse . + displayName: Install dependencies + - bash: cibuildwheel --output-dir wheelhouse . + displayName: Build wheels - task: PublishBuildArtifacts@1 inputs: {pathtoPublish: 'wheelhouse'} @@ -16,13 +17,13 @@ jobs: pool: {vmImage: 'macOS-10.15'} steps: - task: UsePythonVersion@0 - - displayName: Install dependencies - bash: | + - bash: | set -o errexit python3 -m pip install --upgrade pip python3 -m pip install cibuildwheel==1.6.4 - - displayName: Build wheels - bash: cibuildwheel --output-dir wheelhouse . + displayName: Install dependencies + - bash: cibuildwheel --output-dir wheelhouse . + displayName: Build wheels - task: PublishBuildArtifacts@1 inputs: {pathtoPublish: wheelhouse} @@ -36,7 +37,8 @@ jobs: set -o errexit python -m pip install --upgrade pip pip install cibuildwheel==1.6.4 - - displayName: Build wheels - bash: cibuildwheel --output-dir wheelhouse . + displayName: Install dependencies + - bash: cibuildwheel --output-dir wheelhouse . + displayName: Build wheels - task: PublishBuildArtifacts@1 inputs: {pathtoPublish: 'wheelhouse'}