refactor: subprocess.run (#592)
* change check_call to run * refactor: change check_output to run * Apply suggestions from code review Co-authored-by: Joe Rickerby <joerick@mac.com> Co-authored-by: Joe Rickerby <joerick@mac.com>
This commit is contained in:
co-authored by
Joe Rickerby
parent
58c5e56e9f
commit
d2772c2293
@@ -8,7 +8,7 @@ EnvironmentExecutor = Callable[[List[str], Dict[str, str]], str]
|
||||
|
||||
|
||||
def local_environment_executor(command: List[str], env: Dict[str, str]) -> str:
|
||||
return subprocess.check_output(command, env=env, universal_newlines=True)
|
||||
return subprocess.run(command, env=env, universal_newlines=True, stdout=subprocess.PIPE, check=True).stdout
|
||||
|
||||
|
||||
class NodeExecutionContext(NamedTuple):
|
||||
|
||||
Reference in New Issue
Block a user