fix: util.move_file shall not use log.notice (#1862)

Using  `log.notice` result in many unwanted annotations, at least in GitHub Actions.
If we want to print some information about a specific file being moved, it shall be done by the caller - or adding an option to the function - and use `print`.
This commit is contained in:
Matthieu Darbois
2024-06-09 19:03:12 +02:00
committed by GitHub
parent 130fdd2548
commit c37e5a2d13
+2 -8
View File
@@ -375,11 +375,7 @@ def move_file(src_file: Path, dst_file: Path) -> Path:
NotADirectoryError: If any part of the intermediate path to `dst_file` is an existing file
IsADirectoryError: If `dst_file` points directly to an existing directory
"""
# Importing here as logger needs various functions from util -> circular imports
from .logger import log
src_file = src_file.resolve()
src_file = src_file.resolve(strict=True)
dst_file = dst_file.resolve()
if dst_file.is_dir():
@@ -391,9 +387,7 @@ def move_file(src_file: Path, dst_file: Path) -> Path:
# using shutil.move() as Path.rename() is not guaranteed to work across filesystem boundaries
# explicit str() needed for Python 3.8
resulting_file = shutil.move(str(src_file), str(dst_file))
resulting_file = Path(resulting_file).resolve()
log.notice(f"Moved {src_file} to {resulting_file}")
return Path(resulting_file)
return Path(resulting_file).resolve(strict=True)
class DependencyConstraints: