Hongru/cibuildwheel
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

chore: add unit tests for OCIContainer._get_platform_args (#2878)

Browse Source 
* chore: add unit tests for `OCIContainer._get_platform_args`

While this was already tested indirectly through `test_local_image`, this makes the behaviour check of `OCIContainer._get_platform_args` clear.

* fix: re-add `check=False` removed at some point in local testing
This commit is contained in:
Matthieu Darbois
2026-05-31 17:57:40 -04:00
committed by GitHub
parent cd38ee1548
commit acdba60d3a
2 changed files with 18 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
cibuildwheel/oci_container.py
+1
View File
@@ -257,6 +257,7 @@ class OCIContainer:
# this allows to run local only images
pull = "never"
except subprocess.CalledProcessError:
# silently fallback to "--pull=always"
pass
return f"--platform={oci_platform.value}", f"--pull={pull}"
unit_test/oci_container_test.py
+17 -2
View File
@@ -568,13 +568,20 @@ def test_local_image(
[container_engine.name, "pull", f"--platform={platform.value}", remote_image],
check=True,
)
container = OCIContainer(engine=container_engine, image=local_image, oci_platform=platform)
# before image is built & available, we want to pull it
subprocess.run([container_engine.name, "rmi", local_image], check=False)
assert container._get_platform_args() == (f"--platform={platform.value}", "--pull=always")
subprocess.run(
[container_engine.name, "build", f"--platform={platform.value}", "-t", local_image, "."],
check=True,
cwd=tmp_path,
)
with OCIContainer(engine=container_engine, image=local_image, oci_platform=platform):
pass
# after image is built & available, we never want to pull it
expected_platform_args = f"--platform={platform.value}", "--pull=never"
assert container._get_platform_args() == expected_platform_args
with container:
assert container._get_platform_args() == expected_platform_args
@pytest.mark.parametrize("platform", list(OCIPlatform))
@@ -612,6 +619,14 @@ def test_multiarch_image(container_engine: OCIContainerEngineConfig, platform: O
OCIPlatform.S390X: "s390x",
}
assert output_map_dpkg[platform] == output.strip()
# There's no way to check reliably the presence of a specific platform image in the local
# store when the image storage backend supports multi-platform images (such as containerd).
# When platform != DEFAULT_OCI_PLATFORM and the image storage backend supports
# multi-platform images, _get_platform_args will return "--pull=always", at least when the
# DEFAULT_OCI_PLATFORM image is present.
if platform == DEFAULT_OCI_PLATFORM:
expected_platform_args = f"--platform={platform.value}", "--pull=never"
assert container._get_platform_args() == expected_platform_args
@pytest.mark.parametrize(