fix: fallthrough empty manylinux images (#829)

* fix: fall through if empty for manylinux * refactor: review cleanup
2021-09-17 15:52:43 -04:00
parent fded547220
commit a665fb7746
4 changed files with 85 additions and 14 deletions
@@ -291,9 +291,9 @@ def main() -> None:
        for build_platform in MANYLINUX_ARCHS:
            pinned_images = all_pinned_docker_images[build_platform]

-            config_value = options(f"manylinux-{build_platform}-image")
+            config_value = options(f"manylinux-{build_platform}-image", ignore_empty=True)

-            if config_value is None:
+            if not config_value:
                # default to manylinux2010 if it's available, otherwise manylinux2014
                image = pinned_images.get("manylinux2010") or pinned_images.get("manylinux2014")
            elif config_value in pinned_images: