Hongru/cibuildwheel
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Apply suggestions from code review

Browse Source 
Co-authored-by: Henry Schreiner <HenrySchreinerIII@gmail.com>
This commit is contained in:
Joe Rickerby
2023-05-26 15:58:18 +01:00
committed by GitHub
co-authored by Henry Schreiner
parent abc10b603b
commit 9b904777d4
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
cibuildwheel/oci_container.py
+1 -1
View File
@@ -32,7 +32,7 @@ class OCIContainerEngineConfig:
def from_config_string(config_string: str) -> OCIContainerEngineConfig: def from_config_string(config_string: str) -> OCIContainerEngineConfig:
config_dict = parse_key_value_string(config_string, ["name"]) config_dict = parse_key_value_string(config_string, ["name"])
name = " ".join(config_dict["name"]) name = " ".join(config_dict["name"])
if name not in ["docker", "podman"]: if name not in {"docker", "podman"}:
msg = f"unknown container engine {name}" msg = f"unknown container engine {name}"
raise ValueError(msg) raise ValueError(msg)
unit_test/oci_container_test.py
+1 -1
View File
@@ -21,7 +21,7 @@ from cibuildwheel.oci_container import OCIContainer, OCIContainerEngineConfig
pm = platform.machine() pm = platform.machine()
if pm == "x86_64": if pm == "x86_64":
DEFAULT_IMAGE = "quay.io/pypa/manylinux2014_x86_64:2020-05-17-2f8ac3b" DEFAULT_IMAGE = "quay.io/pypa/manylinux2014_x86_64:2020-05-17-2f8ac3b"
elif pm in ["aarch64", "arm64"]: elif pm in {"aarch64", "arm64"}:
DEFAULT_IMAGE = "quay.io/pypa/manylinux2014_aarch64:2020-05-17-2f8ac3b" DEFAULT_IMAGE = "quay.io/pypa/manylinux2014_aarch64:2020-05-17-2f8ac3b"
elif pm == "ppc64le": elif pm == "ppc64le":
DEFAULT_IMAGE = "quay.io/pypa/manylinux2014_ppc64le:2020-05-17-2f8ac3b" DEFAULT_IMAGE = "quay.io/pypa/manylinux2014_ppc64le:2020-05-17-2f8ac3b"