From 9b904777d4c3dd275fa23ca567c4e1ec4fa2b951 Mon Sep 17 00:00:00 2001 From: Joe Rickerby Date: Fri, 26 May 2023 15:58:18 +0100 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Henry Schreiner --- cibuildwheel/oci_container.py | 2 +- unit_test/oci_container_test.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/cibuildwheel/oci_container.py b/cibuildwheel/oci_container.py index ac71e984..e0700126 100644 --- a/cibuildwheel/oci_container.py +++ b/cibuildwheel/oci_container.py @@ -32,7 +32,7 @@ class OCIContainerEngineConfig: def from_config_string(config_string: str) -> OCIContainerEngineConfig: config_dict = parse_key_value_string(config_string, ["name"]) name = " ".join(config_dict["name"]) - if name not in ["docker", "podman"]: + if name not in {"docker", "podman"}: msg = f"unknown container engine {name}" raise ValueError(msg) diff --git a/unit_test/oci_container_test.py b/unit_test/oci_container_test.py index 617529ca..ccbd0555 100644 --- a/unit_test/oci_container_test.py +++ b/unit_test/oci_container_test.py @@ -21,7 +21,7 @@ from cibuildwheel.oci_container import OCIContainer, OCIContainerEngineConfig pm = platform.machine() if pm == "x86_64": DEFAULT_IMAGE = "quay.io/pypa/manylinux2014_x86_64:2020-05-17-2f8ac3b" -elif pm in ["aarch64", "arm64"]: +elif pm in {"aarch64", "arm64"}: DEFAULT_IMAGE = "quay.io/pypa/manylinux2014_aarch64:2020-05-17-2f8ac3b" elif pm == "ppc64le": DEFAULT_IMAGE = "quay.io/pypa/manylinux2014_ppc64le:2020-05-17-2f8ac3b"