Apply suggestions from code review
Co-authored-by: Henry Schreiner <HenrySchreinerIII@gmail.com>
This commit is contained in:
co-authored by
Henry Schreiner
parent
abc10b603b
commit
9b904777d4
@@ -32,7 +32,7 @@ class OCIContainerEngineConfig:
|
||||
def from_config_string(config_string: str) -> OCIContainerEngineConfig:
|
||||
config_dict = parse_key_value_string(config_string, ["name"])
|
||||
name = " ".join(config_dict["name"])
|
||||
if name not in ["docker", "podman"]:
|
||||
if name not in {"docker", "podman"}:
|
||||
msg = f"unknown container engine {name}"
|
||||
raise ValueError(msg)
|
||||
|
||||
|
||||
@@ -21,7 +21,7 @@ from cibuildwheel.oci_container import OCIContainer, OCIContainerEngineConfig
|
||||
pm = platform.machine()
|
||||
if pm == "x86_64":
|
||||
DEFAULT_IMAGE = "quay.io/pypa/manylinux2014_x86_64:2020-05-17-2f8ac3b"
|
||||
elif pm in ["aarch64", "arm64"]:
|
||||
elif pm in {"aarch64", "arm64"}:
|
||||
DEFAULT_IMAGE = "quay.io/pypa/manylinux2014_aarch64:2020-05-17-2f8ac3b"
|
||||
elif pm == "ppc64le":
|
||||
DEFAULT_IMAGE = "quay.io/pypa/manylinux2014_ppc64le:2020-05-17-2f8ac3b"
|
||||
|
||||
Reference in New Issue
Block a user