From 8d9d9708742340bb8b88ca146566021dd4c1a25a Mon Sep 17 00:00:00 2001 From: Yannick Jadoul Date: Sun, 8 Apr 2018 21:48:27 +0200 Subject: [PATCH] Fixing empty verbosity flag argument to `subprocess.check_call` --- cibuildwheel/macos.py | 3 ++- cibuildwheel/windows.py | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/cibuildwheel/macos.py b/cibuildwheel/macos.py index 840b4618..a8ea4d74 100644 --- a/cibuildwheel/macos.py +++ b/cibuildwheel/macos.py @@ -87,7 +87,8 @@ def build(project_dir, package_name, output_dir, test_command, test_requires, be call(before_build_prepared, env=env, shell=True) # build the wheel - call([pip, 'wheel', abs_project_dir, '-w', '/tmp/built_wheel', '--no-deps', get_build_verbosity_flag(build_verbosity)], env=env) + build_verbosity_flag = get_build_verbosity_flag(build_verbosity) + call([pip, 'wheel', abs_project_dir, '-w', '/tmp/built_wheel', '--no-deps'] + ([build_verbosity_flag] if build_verbosity_flag else []), env=env) built_wheel = glob('/tmp/built_wheel/*.whl')[0] if built_wheel.endswith('none-any.whl'): diff --git a/cibuildwheel/windows.py b/cibuildwheel/windows.py index fc9ac448..ad1bd61c 100644 --- a/cibuildwheel/windows.py +++ b/cibuildwheel/windows.py @@ -82,7 +82,8 @@ def build(project_dir, package_name, output_dir, test_command, test_requires, be shell([before_build_prepared], env=env) # build the wheel - shell(['pip', 'wheel', abs_project_dir, '-w', built_wheel_dir, '--no-deps', get_build_verbosity_flag(build_verbosity)], env=env) + build_verbosity_flag = get_build_verbosity_flag(build_verbosity) + shell(['pip', 'wheel', abs_project_dir, '-w', built_wheel_dir, '--no-deps'] + ([build_verbosity_flag] if build_verbosity_flag else []), env=env) built_wheel = glob(built_wheel_dir+'/*.whl')[0] # install the wheel