From 84b518a1b1aed68be73fc8809a0502dff4985121 Mon Sep 17 00:00:00 2001 From: Matthieu Darbois Date: Sat, 6 Jun 2026 14:19:14 +0200 Subject: [PATCH] chore: simplify pinned image lookup (#2897) Replace the explicit if/else used to resolve pinned container images with pinned_images.get(config_value, config_value) in the manylinux and musllinux loops inside _compute_build_options. This keeps behavior identical while reducing duplication and simplifying the code in cibuildwheel/options.py. --- cibuildwheel/options.py | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/cibuildwheel/options.py b/cibuildwheel/options.py index 20607e5c..ed39bf35 100644 --- a/cibuildwheel/options.py +++ b/cibuildwheel/options.py @@ -880,11 +880,7 @@ class Options: f"manylinux-{build_platform}-image", ignore_empty=True ) self._check_pinned_image(config_value, pinned_images) - if config_value in pinned_images: - image = pinned_images[config_value] - else: - image = config_value - manylinux_images[build_platform] = image + manylinux_images[build_platform] = pinned_images.get(config_value, config_value) for build_platform in MUSLLINUX_ARCHS: pinned_images = all_pinned_container_images[build_platform] @@ -892,11 +888,7 @@ class Options: f"musllinux-{build_platform}-image", ignore_empty=True ) self._check_pinned_image(config_value, pinned_images) - if config_value in pinned_images: - image = pinned_images[config_value] - else: - image = config_value - musllinux_images[build_platform] = image + musllinux_images[build_platform] = pinned_images.get(config_value, config_value) container_engine_str = self.reader.get( "container-engine",