From 7af9d039fbffdde9ef04ad9cb661fa73914b5c9f Mon Sep 17 00:00:00 2001 From: Matthieu Darbois Date: Sun, 21 Jul 2024 10:51:43 +0200 Subject: [PATCH] fix: do not use uv on Windows PyPy 3.8 (#1941) fix: do not use uv on PyPy 3.8 uv 0.2.25+ does not work with PyPy 3.8 Given PyPy 3.8 is EOL, just disable uv for this config rather than ask for it to be supported again in uv. --- cibuildwheel/windows.py | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/cibuildwheel/windows.py b/cibuildwheel/windows.py index a1528844..1651fecb 100644 --- a/cibuildwheel/windows.py +++ b/cibuildwheel/windows.py @@ -254,8 +254,10 @@ def setup_python( raise ValueError(msg) assert base_python.exists() - use_uv = build_frontend == "build[uv]" and Version(python_configuration.version) >= Version( - "3.8" + use_uv = ( + build_frontend == "build[uv]" + and Version(python_configuration.version) >= Version("3.8") + and not python_configuration.identifier.startswith("pp38-") ) uv_path = find_uv() @@ -366,8 +368,10 @@ def build(options: Options, tmp_path: Path) -> None: for config in python_configurations: build_options = options.build_options(config.identifier) build_frontend = build_options.build_frontend or BuildFrontendConfig("pip") - use_uv = build_frontend.name == "build[uv]" and Version(config.version) >= Version( - "3.8" + use_uv = ( + build_frontend.name == "build[uv]" + and Version(config.version) >= Version("3.8") + and not config.identifier.startswith("pp38-") ) log.build_start(config.identifier)