Hongru/cibuildwheel
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Improvements from code review

Browse Source
This commit is contained in:
Joe Rickerby
2020-11-04 11:11:42 +00:00
parent c5bbfb3cc6
commit 75c6e6a0a4
2 changed files with 5 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
cibuildwheel/linux.py
-6
View File
@@ -264,12 +264,6 @@ def build(options: BuildOptions) -> None:
exit(1) exit(1)
def build_one(options: BuildOptions, config: PythonConfiguration, docker: DockerContainer,
container_project_path: PurePath, container_package_dir: PurePath,
container_output_dir: PurePath, log: Logger):
pass
def troubleshoot(package_dir: Path, error: Exception) -> None: def troubleshoot(package_dir: Path, error: Exception) -> None:
if (isinstance(error, subprocess.CalledProcessError) and error.cmd[0:2] == ['pip', 'wheel']): if (isinstance(error, subprocess.CalledProcessError) and error.cmd[0:2] == ['pip', 'wheel']):
# the 'pip wheel' step failed. # the 'pip wheel' step failed.
cibuildwheel/logger.py
+5 -6
View File
@@ -11,11 +11,11 @@ FOLD_PATTERNS = {
} }
PLATFORM_IDENTIFIER_DESCIPTIONS = { PLATFORM_IDENTIFIER_DESCIPTIONS = {
'manylinux_x86_64': 'Manylinux x86_64', 'manylinux_x86_64': 'manylinux x86_64',
'manylinux_i686': 'Manylinux i686', 'manylinux_i686': 'manylinux i686',
'manylinux_aarch64': 'Manylinux aarch64', 'manylinux_aarch64': 'manylinux aarch64',
'manylinux_ppc64le': 'Manylinux ppc64le', 'manylinux_ppc64le': 'manylinux ppc64le',
'manylinux_s390x': 'Manylinux s390x', 'manylinux_s390x': 'manylinux s390x',
'win32': 'Windows 32bit', 'win32': 'Windows 32bit',
'win_amd64': 'Windows 64bit', 'win_amd64': 'Windows 64bit',
'macosx_x86_64': 'macOS x86_64', 'macosx_x86_64': 'macOS x86_64',
@@ -108,7 +108,6 @@ class Logger:
fold_start_pattern = FOLD_PATTERNS.get(self.fold_mode, DEFAULT_FOLD_PATTERN)[0] fold_start_pattern = FOLD_PATTERNS.get(self.fold_mode, DEFAULT_FOLD_PATTERN)[0]
print(fold_start_pattern.format(name=self.active_fold_group_name)) print(fold_start_pattern.format(name=self.active_fold_group_name))
print()
def _end_fold_group(self): def _end_fold_group(self):
if self.active_fold_group_name: if self.active_fold_group_name: