From 75c6e6a0a497f79ba87126b948d1378bc07930b6 Mon Sep 17 00:00:00 2001 From: Joe Rickerby Date: Wed, 4 Nov 2020 11:11:42 +0000 Subject: [PATCH] Improvements from code review --- cibuildwheel/linux.py | 6 ------ cibuildwheel/logger.py | 11 +++++------ 2 files changed, 5 insertions(+), 12 deletions(-) diff --git a/cibuildwheel/linux.py b/cibuildwheel/linux.py index dd7bce32..971a69f9 100644 --- a/cibuildwheel/linux.py +++ b/cibuildwheel/linux.py @@ -264,12 +264,6 @@ def build(options: BuildOptions) -> None: exit(1) -def build_one(options: BuildOptions, config: PythonConfiguration, docker: DockerContainer, - container_project_path: PurePath, container_package_dir: PurePath, - container_output_dir: PurePath, log: Logger): - pass - - def troubleshoot(package_dir: Path, error: Exception) -> None: if (isinstance(error, subprocess.CalledProcessError) and error.cmd[0:2] == ['pip', 'wheel']): # the 'pip wheel' step failed. diff --git a/cibuildwheel/logger.py b/cibuildwheel/logger.py index 5f73d894..5be30243 100644 --- a/cibuildwheel/logger.py +++ b/cibuildwheel/logger.py @@ -11,11 +11,11 @@ FOLD_PATTERNS = { } PLATFORM_IDENTIFIER_DESCIPTIONS = { - 'manylinux_x86_64': 'Manylinux x86_64', - 'manylinux_i686': 'Manylinux i686', - 'manylinux_aarch64': 'Manylinux aarch64', - 'manylinux_ppc64le': 'Manylinux ppc64le', - 'manylinux_s390x': 'Manylinux s390x', + 'manylinux_x86_64': 'manylinux x86_64', + 'manylinux_i686': 'manylinux i686', + 'manylinux_aarch64': 'manylinux aarch64', + 'manylinux_ppc64le': 'manylinux ppc64le', + 'manylinux_s390x': 'manylinux s390x', 'win32': 'Windows 32bit', 'win_amd64': 'Windows 64bit', 'macosx_x86_64': 'macOS x86_64', @@ -108,7 +108,6 @@ class Logger: fold_start_pattern = FOLD_PATTERNS.get(self.fold_mode, DEFAULT_FOLD_PATTERN)[0] print(fold_start_pattern.format(name=self.active_fold_group_name)) - print() def _end_fold_group(self): if self.active_fold_group_name: