Fix some comments from review

This commit is contained in:
Joe Rickerby
2020-03-01 11:09:22 +00:00
parent 8a450b7655
commit 5e16e86355
3 changed files with 7 additions and 2 deletions
-1
View File
@@ -100,4 +100,3 @@ env2/
# VSCode project settings # VSCode project settings
/.vscode /.vscode
env2
+4 -1
View File
@@ -10,7 +10,7 @@ from .util import (
download, download,
get_build_verbosity_extra_flags, get_build_verbosity_extra_flags,
prepare_command, prepare_command,
get_pip_script get_pip_script,
) )
@@ -140,6 +140,9 @@ def build(project_dir, output_dir, test_command, test_requires, test_extras, bef
# there are no dependencies that were pulled in at build time. # there are no dependencies that were pulled in at build time.
call(['pip', 'install', 'virtualenv'] + dependency_constraint_flags, env=env) call(['pip', 'install', 'virtualenv'] + dependency_constraint_flags, env=env)
venv_dir = tempfile.mkdtemp() venv_dir = tempfile.mkdtemp()
# Use --no-download to ensure determinism by using seed libraries
# built into virtualenv
call(['python', '-m', 'virtualenv', '--no-download', venv_dir], env=env) call(['python', '-m', 'virtualenv', '--no-download', venv_dir], env=env)
virtualenv_env = env.copy() virtualenv_env = env.copy()
+3
View File
@@ -152,6 +152,9 @@ def build(project_dir, output_dir, test_command, test_requires, test_extras, bef
# there are no dependencies that were pulled in at build time. # there are no dependencies that were pulled in at build time.
shell(['pip', 'install', 'virtualenv'] + dependency_constraint_flags, env=env) shell(['pip', 'install', 'virtualenv'] + dependency_constraint_flags, env=env)
venv_dir = tempfile.mkdtemp() venv_dir = tempfile.mkdtemp()
# Use --no-download to ensure determinism by using seed libraries
# built into virtualenv
shell(['python', '-m', 'virtualenv', '--no-download', venv_dir], env=env) shell(['python', '-m', 'virtualenv', '--no-download', venv_dir], env=env)
virtualenv_env = env.copy() virtualenv_env = env.copy()