From 5e16e8635577505312aff17f0ea86607cdc81097 Mon Sep 17 00:00:00 2001 From: Joe Rickerby Date: Sun, 1 Mar 2020 11:09:22 +0000 Subject: [PATCH] Fix some comments from review --- .gitignore | 1 - cibuildwheel/macos.py | 5 ++++- cibuildwheel/windows.py | 3 +++ 3 files changed, 7 insertions(+), 2 deletions(-) diff --git a/.gitignore b/.gitignore index f642585d..627af7b1 100644 --- a/.gitignore +++ b/.gitignore @@ -100,4 +100,3 @@ env2/ # VSCode project settings /.vscode -env2 diff --git a/cibuildwheel/macos.py b/cibuildwheel/macos.py index 383f6453..40c8e8c3 100644 --- a/cibuildwheel/macos.py +++ b/cibuildwheel/macos.py @@ -10,7 +10,7 @@ from .util import ( download, get_build_verbosity_extra_flags, prepare_command, - get_pip_script + get_pip_script, ) @@ -140,6 +140,9 @@ def build(project_dir, output_dir, test_command, test_requires, test_extras, bef # there are no dependencies that were pulled in at build time. call(['pip', 'install', 'virtualenv'] + dependency_constraint_flags, env=env) venv_dir = tempfile.mkdtemp() + + # Use --no-download to ensure determinism by using seed libraries + # built into virtualenv call(['python', '-m', 'virtualenv', '--no-download', venv_dir], env=env) virtualenv_env = env.copy() diff --git a/cibuildwheel/windows.py b/cibuildwheel/windows.py index b62e7801..ab15db37 100644 --- a/cibuildwheel/windows.py +++ b/cibuildwheel/windows.py @@ -152,6 +152,9 @@ def build(project_dir, output_dir, test_command, test_requires, test_extras, bef # there are no dependencies that were pulled in at build time. shell(['pip', 'install', 'virtualenv'] + dependency_constraint_flags, env=env) venv_dir = tempfile.mkdtemp() + + # Use --no-download to ensure determinism by using seed libraries + # built into virtualenv shell(['python', '-m', 'virtualenv', '--no-download', venv_dir], env=env) virtualenv_env = env.copy()