From 45074a9b3a67f30a7ec718b347612bb846357f54 Mon Sep 17 00:00:00 2001 From: Henry Schreiner Date: Thu, 13 Aug 2020 20:50:36 -0400 Subject: [PATCH] fix: add extra space after ] --- cibuildwheel/windows.py | 5 ++++- test/test_pep518.py | 4 ++++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/cibuildwheel/windows.py b/cibuildwheel/windows.py index f793acf4..4ebdf691 100644 --- a/cibuildwheel/windows.py +++ b/cibuildwheel/windows.py @@ -177,8 +177,11 @@ def pep_518_cp35_workaround(package_dir: Path, env: Dict[str, str]) -> None: if 'build-system' in data else [] ) + if requirements: - shell(['pip', 'install'] + requirements, env=env) + # Workaround for bug when ]>= is present, #421 + requirements = [r.replace("]", "] ") for r in requirements] + call(['pip', 'install'] + requirements, env=env) def build(options: BuildOptions) -> None: diff --git a/test/test_pep518.py b/test/test_pep518.py index 9257f7db..fe8f8174 100644 --- a/test/test_pep518.py +++ b/test/test_pep518.py @@ -27,6 +27,7 @@ basic_project.files[ [build-system] requires = [ "setuptools >= 42", + "setuptools_scm[toml]>=4.1.2", "wheel", "requests==2.22.0; python_version<'3.6'", "requests==2.23.0; python_version>='3.6'" @@ -47,3 +48,6 @@ def test_pep518(tmp_path): # check that the expected wheels are produced expected_wheels = utils.expected_wheels("spam", "0.1.0") assert set(actual_wheels) == set(expected_wheels) + + assert not (project_dir / "42").exists() + assert not (project_dir / "4.1.2").exists()