fix: report defects in logs and HTML summaries (#2512)

* BUG: fix incorrect reporting of number of wheels produced

* BUG: fix incorrect naming of test only sessions in html summaries
This commit is contained in:
Clément Robert
2025-07-24 12:28:30 -04:00
committed by GitHub
parent ffd835cef1
commit 1ac7fa7f00
2 changed files with 5 additions and 5 deletions
+4 -4
View File
@@ -242,11 +242,11 @@ class Logger:
github_summary = self._github_step_summary(duration=duration, options=options) github_summary = self._github_step_summary(duration=duration, options=options)
Path(summary_path).write_text(filter_ansi_codes(github_summary), encoding="utf-8") Path(summary_path).write_text(filter_ansi_codes(github_summary), encoding="utf-8")
n = len(self.summary) n_wheels = len([info for info in self.summary if not info.filename])
s = "s" if n > 1 else "" s = "s" if n_wheels > 1 else ""
duration_str = humanize.naturaldelta(duration) duration_str = humanize.naturaldelta(duration)
print() print()
self._start_fold_group(f"{n} wheel{s} produced in {duration_str}") self._start_fold_group(f"{n_wheels} wheel{s} produced in {duration_str}")
for build_info in self.summary: for build_info in self.summary:
print(" ", build_info) print(" ", build_info)
self._end_fold_group() self._end_fold_group()
@@ -320,7 +320,7 @@ class Logger:
n_wheels = len([b for b in self.summary if b.filename]) n_wheels = len([b for b in self.summary if b.filename])
wheel_rows = "\n".join( wheel_rows = "\n".join(
"<tr>" "<tr>"
f"<td nowrap>{'<samp>' + b.filename.name + '</samp>' if b.filename else '*Build only*'}</td>" f"<td nowrap>{'<samp>' + b.filename.name + '</samp>' if b.filename else '*Test only*'}</td>"
f"<td nowrap>{b.size or 'N/A'}</td>" f"<td nowrap>{b.size or 'N/A'}</td>"
f"<td nowrap><samp>{b.identifier}</samp></td>" f"<td nowrap><samp>{b.identifier}</samp></td>"
f"<td nowrap>{humanize.naturaldelta(b.duration)}</td>" f"<td nowrap>{humanize.naturaldelta(b.duration)}</td>"
+1 -1
View File
@@ -25,7 +25,7 @@ def test_printout_wheels(capsys):
assert "id1" in captured.out assert "id1" in captured.out
assert "id2" in captured.out assert "id2" in captured.out
assert "wheels produced in" in captured.out assert "1 wheel produced in" in captured.out
assert "SHA256=" in captured.out assert "SHA256=" in captured.out